crypto: Remove inner mutable shared state from Account
#2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjbvr
force-pushed
the
storetransaction-optional-account
branch
from
caacc24 to
04396eb
Compare
17 tasks
bnjbvr
force-pushed
the
storetransaction-optional-account
branch
from
3c6fdb9 to
4df2d96
Compare
…uery The store cache can be filled lazily when it's actually needed. It's not needed in this function here, and may be needed in another function the caller of this function may call later. No need to preemptively fill the cache here.
bnjbvr
force-pushed
the
storetransaction-optional-account
branch
from
4df2d96 to
7eb71f9
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2710 +/- ##
==========================================
- Coverage 78.71% 78.68% -0.03%
==========================================
Files 200 200
Lines 20359 20392 +33
==========================================
+ Hits 16025 16046 +21
- Misses 4334 4346 +12
☔ View full report in Codecov by Sentry. |
jplatte
reviewed
Oct 20, 2023
poljar
reviewed
Oct 20, 2023
poljar
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Looks good.
Suggested some small changes in a review party:
- Using a result in tests usually produces worse error reports if a test fails
- Let's not use
clone_internal()in non-test code - Something for the future, try out if the
OwnedRwLockGuardis necessary, maybe we can use the non-owned variant.
Thanks for methodically going through the mess and making sense of it, very nice work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Accountis lazily loaded in the cache, and transferred from the cache toPendingChangesin case ofStoreTransaction. Later,Accountis made not cloneable anymore, and inner mutable shared state is removed from there, so we can identify which interactions with the cache must be transactions (i.e. which Account function calls require write access), and which can just be reads from the cache (i.e. which Account function calls requires read-only access). Eventually, the cache is put behind a RwLock, so we can't read and write to the cache at the same time; this lock is taken in write access during transactions, and in read-only access during cache reads.This can be reviewed commit by commit.
Multiple parts of #2624.